[PATCH] D26716: DAG: Ignore call site attributes when emitting target intrinsic

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 10:38:32 PST 2016


hfinkel added a comment.

In https://reviews.llvm.org/D26716#597575, @efriedma wrote:

> Why can't you just compute whether the intrinsic has a chain based on the IntrinsicInfo?  Checking for a readnone attribute in the IR seems dubious at best; an intrinsic can be both readnone and require a chain (for example, it could have undefined behavior for some inputs).


For what exactly are you asking? We can call getTgtMemIntrinsic, but the fall-back behavior would be the same (unless you want this to be a large behavioral change). The UB issue is potentially important, if we have readonly/readnone target intrinsics with UB, but that seems like a pre-existing issue.


https://reviews.llvm.org/D26716





More information about the llvm-commits mailing list