[PATCH] D26906: [ELF] Convert EhFrameHeader to input section

[George Rimar via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:39
 using namespace llvm;
+using namespace llvm::dwarf;
 using namespace llvm::ELF;
----------------
I think it is not ordered. Because for example we have

```
using namespace llvm;
using namespace llvm::dwarf;
using namespace llvm::object;
using namespace llvm::support::endian;
using namespace llvm::ELF;
```

In OutputSections.cpp file, so looks we separate uppercase and lowercase elements.


================
Comment at: ELF/Writer.cpp:986
+                           In<ELFT>::EhFrameHdr, In<ELFT>::Dynamic});
 }
 
----------------
Not sure if this is formatted (looks a bit strange in phab-view for me).


Repository:
  rL LLVM

https://reviews.llvm.org/D26906