[PATCH] D26890: SHA1: unroll loop in hashBlock.

[Davide Italiano via llvm-commits]

davide added inline comments.


================
Comment at: lib/Support/SHA1.cpp:30
 
+#define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - (bits))))
+
----------------
mehdi_amini wrote:
> Why did you turn it into a macro?
Agree, not particularly fond of macros in new software unless really needed.


https://reviews.llvm.org/D26890