[PATCH] D26183: [compiler-rt] builtins: Allow building windows arm functions for mingw

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 19 13:12:42 PST 2016


mstorsjo added inline comments.


================
Comment at: lib/builtins/arm/aeabi_uldivmod.S:36
+        mov     r1, r3
+        mov     r3, r12
+#endif
----------------
compnerd wrote:
> Prefer `ip` over `r12`.  Its easier to remember that as a mnemonic (intra-procedural [scratch]).
Ok, I can change that, but do note that the existing code already uses `r12` and not `ip`, right above this block. Do you still prefer `ip` while making it inconsistent with the rest?


https://reviews.llvm.org/D26183





More information about the llvm-commits mailing list