[PATCH] D26556: [InstCombine] don't widen most selects by hoisting an extend

[Sanjay Patel via llvm-commits]

spatel updated this revision to Diff 78633.
spatel added a comment.

Patch updated:
0. Preliminary: added a pile of tests for permutations of trunc/sel/ext with https://reviews.llvm.org/rL287400 .

1. Added a function specifically to handle widening of select, so (in theory) we have this transform in one place and can do it in a principled way.
2. But some of the tests still show the (unwanted?) changes noted in Filipe's example.
3. Added TODO comments where those happen (we treat vectors differently than scalars).
4. Added a FIXME because we're dropping profile metadata for all of these select transforms.


https://reviews.llvm.org/D26556

Files:
  lib/Transforms/InstCombine/InstCombineCasts.cpp
  lib/Transforms/InstCombine/InstructionCombining.cpp
  test/Transforms/InstCombine/select-bitext.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26556.78633.patch
Type: text/x-patch
Size: 18892 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161119/1cd6ed6a/attachment.bin>