[PATCH] D26884: Change setDiagnosticsOutputFile to take a unique_ptr from a raw pointer (NFC)

Malcolm Parsons via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 19 00:38:44 PST 2016


malcolm.parsons added inline comments.


================
Comment at: llvm/include/llvm/IR/LLVMContext.h:197
   /// set, the handler is invoked for each diagnostic message.
-  void setDiagnosticsOutputFile(yaml::Output *F);
+  void setDiagnosticsOutputFile(std::unique_ptr<yaml::Output> F);
 
----------------
Pass by value if always moving doesn't apply to move-only types. Use && to avoid a temporary.


https://reviews.llvm.org/D26884





More information about the llvm-commits mailing list