[PATCH] D26872: Outliner: Add MIR-level outlining pass

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 15:13:42 PST 2016


davide added a comment.

Couple of questions (I'd like to complete the review of the other two patches before jumping to this one).

1. Your original RFC mentions that you planned to re-implement the outliner using another data structure as building block, i.e. a SuffixArray, but here I see you're still using a SuffixTree. Did you change your mind and/or are you going to leave it as a future improvement?
2. I saw the figures when running the outliner on the LLVM testsuite, but I wonder if you tried/tested got the numbers on larger testcases? For example, clang/lld/firefox/chromium?


Repository:
  rL LLVM

https://reviews.llvm.org/D26872





More information about the llvm-commits mailing list