[PATCH] D12067: AMDGPU: Refactor exp instructions

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 10:49:57 PST 2016


arsenm added a comment.

In https://reviews.llvm.org/D12067#599858, @nhaehnle wrote:

> The TODOs need to be addressed, and for the FIXMEs in the intrinsic definition, I'd say we're better off just adding a real llvm.amdgcn.export (+ .done?) intrinsic in the future. Some more inline comments, but overall I think this patch is fine.


The only TODOs I see left are addressed in the https://reviews.llvm.org/D12068


https://reviews.llvm.org/D12067





More information about the llvm-commits mailing list