[PATCH] D26005: AMDGPU: Don't use stack space for SGPR->VGPR spills

[Nicolai Hähnle via llvm-commits]

nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:117-118
+
   // Skip the last 2 elements because the last one is reserved for VCC, and
   // this is the 2nd to last element already.
+  for (MCPhysReg Reg : AllSGPR128s) {
----------------
arsenm wrote:
> nhaehnle wrote:
> > The comment doesn't match the code anymore. Was the drop_back(2) removed on purpose? It seems like it would still be needed.
> Yes, although I'm having trouble remembering why exactly. I think it should be redundant with the isReserved check
Yes, the isAllocatable should cover it. But please still update the comment and the whitespace change below. Apart from that, the patch LGTM.


https://reviews.llvm.org/D26005