[PATCH] D26765: GlobalISel: Fix unconditional fallback with global isel abort is disabled

Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 06:24:32 PST 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL287344: GlobalISel: Fix unconditional fallback with global isel abort is disabled (authored by tstellar).

Changed prior to commit:
  https://reviews.llvm.org/D26765?vs=78247&id=78514#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D26765

Files:
  llvm/trunk/lib/CodeGen/GlobalISel/InstructionSelect.cpp
  llvm/trunk/test/CodeGen/AArch64/GlobalISel/gisel-abort.ll


Index: llvm/trunk/test/CodeGen/AArch64/GlobalISel/gisel-abort.ll
===================================================================
--- llvm/trunk/test/CodeGen/AArch64/GlobalISel/gisel-abort.ll
+++ llvm/trunk/test/CodeGen/AArch64/GlobalISel/gisel-abort.ll
@@ -0,0 +1,8 @@
+; RUN: llc -march aarch64 -global-isel -global-isel-abort=2 -verify-machineinstrs %s -o - 2>&1 | FileCheck %s
+
+; CHECK-NOT: fallback
+; CHECK: empty
+define void @empty() {
+  ret void
+}
+
Index: llvm/trunk/lib/CodeGen/GlobalISel/InstructionSelect.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/GlobalISel/InstructionSelect.cpp
+++ llvm/trunk/lib/CodeGen/GlobalISel/InstructionSelect.cpp
@@ -164,7 +164,7 @@
 
   MRI.getVRegToType().clear();
 
-  if (!TPC.isGlobalISelAbortEnabled() && (Failed || MF.size() == NumBlocks)) {
+  if (!TPC.isGlobalISelAbortEnabled() && (Failed || MF.size() != NumBlocks)) {
     MF.getProperties().set(MachineFunctionProperties::Property::FailedISel);
     return false;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26765.78514.patch
Type: text/x-patch
Size: 1035 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161118/852efe45/attachment.bin>


More information about the llvm-commits mailing list