[lld] r287237 - Enable -threads by default.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 06:02:30 PST 2016


Thanks.  I have added a new version of the benchmarks I use to
https://drive.google.com/open?id=0B7iRtublysV6S1lGYnViYWRVWnc . They
now pass --no-threads.

Cheers,
Rafael


On 17 November 2016 at 12:06, Rui Ueyama via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: ruiu
> Date: Thu Nov 17 11:06:51 2016
> New Revision: 287237
>
> URL: http://llvm.org/viewvc/llvm-project?rev=287237&view=rev
> Log:
> Enable -threads by default.
>
> LLD supports multi-threading, and it seems to be working well as
> you can see in r287140. In short, LLD runs a few percent to 30%
> faster with -threads and more than 50% faster if you are using
> -build-id (your mileage may vary depending on your computer).
>
> However, I don't think most users even don't know about that because
> -threads is not a default option.
>
> This patch enables it by default.
>
> Discussion thread:
> http://lists.llvm.org/pipermail/llvm-dev/2016-November/107160.html
>
> Modified:
>     lld/trunk/ELF/Driver.cpp
>
> Modified: lld/trunk/ELF/Driver.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=287237&r1=287236&r2=287237&view=diff
> ==============================================================================
> --- lld/trunk/ELF/Driver.cpp (original)
> +++ lld/trunk/ELF/Driver.cpp Thu Nov 17 11:06:51 2016
> @@ -496,7 +496,7 @@ void LinkerDriver::readConfigs(opt::Inpu
>    Config->SaveTemps = Args.hasArg(OPT_save_temps);
>    Config->Shared = Args.hasArg(OPT_shared);
>    Config->Target1Rel = getArg(Args, OPT_target1_rel, OPT_target1_abs, false);
> -  Config->Threads = getArg(Args, OPT_threads, OPT_no_threads, false);
> +  Config->Threads = getArg(Args, OPT_threads, OPT_no_threads, true);
>    Config->Trace = Args.hasArg(OPT_trace);
>    Config->Verbose = Args.hasArg(OPT_verbose);
>    Config->WarnCommon = Args.hasArg(OPT_warn_common);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list