[polly] r287263 - [DBG] Collect statistics about statically infeasible SCoPs

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 04:51:31 PST 2016


On 11/18, Tobias Grosser wrote:
> On Thu, Nov 17, 2016, at 10:44 PM, Johannes Doerfert via llvm-commits
> wrote:
> > Author: jdoerfert
> > Date: Thu Nov 17 15:44:47 2016
> > New Revision: 287263
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=287263&view=rev
> > Log:
> > [DBG] Collect statistics about statically infeasible SCoPs
> > 
> > Modified:
> >     polly/trunk/lib/Analysis/ScopBuilder.cpp
> > 
> > Modified: polly/trunk/lib/Analysis/ScopBuilder.cpp
> > URL:
> > http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopBuilder.cpp?rev=287263&r1=287262&r2=287263&view=diff
> > ==============================================================================
> > --- polly/trunk/lib/Analysis/ScopBuilder.cpp (original)
> > +++ polly/trunk/lib/Analysis/ScopBuilder.cpp Thu Nov 17 15:44:47 2016
> > @@ -28,6 +28,8 @@ using namespace polly;
> >  
> >  STATISTIC(ScopFound, "Number of valid Scops");
> >  STATISTIC(RichScopFound, "Number of Scops containing a loop");
> > +STATISTIC(INFEASIBLE_SCOPS,
> > +          "Number of SCoPs with statically infeasible context.");
> 
> Hi Johannes,
> 
> thank you for upstreaming these changes!
> 
> One minor comment: Why do you use UPPERCASE for variable names? This
> seems to be contrary to the local coding style and the style used to
> name STATISTIC variables in llvm as well?
Good question. I started in a file without STATISTIC and when I added
the one above I used the same UPPERCASE style. I'll fix it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161118/47fe67cd/attachment.sig>


More information about the llvm-commits mailing list