[PATCH] D26770: [asan] Make ASan compatible with linker dead stripping on Windows

[Bob Haarman via llvm-commits]

inglorion added inline comments.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1566
+  bool UseMachOGlobalsSection = ShouldUseMachOGlobalsSection();
+  bool UseMetadataArray = !(UseComdatMetadata || UseMachOGlobalsSection);
+
----------------
This would make it not use comdat metadata on ELF, right? Would it work to instead do the equivalent of

  bool UseMachOGlobalsSection = ShouldUseMachOGlobalsSection();
  bool UseComdatMetadata = !UseMachOGlobalsSection && TargetTriple.supportsCOMDAT();
  bool UseMetadataArray = !(UseComdatMetadata || UseMachOGlobalsSection);

so that we get the MachO special implementation where applicable, else try to use comdats, and only fall back to the metadata array if neither of the other options will work?


https://reviews.llvm.org/D26770