[PATCH] D26224: NewGVN

[Daniel Berlin via llvm-commits]

On Thu, Nov 17, 2016 at 2:25 PM, Piotr Padlewski <piotr.padlewski at gmail.com>
wrote:

> Prazek added inline comments.
>
>
> ================
> Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:37
> +  ExpressionTypeBasicStart,
> +  ExpressionTypeBasic,
> +  ExpressionTypeCall,
> ----------------
> I am not really sure what does it mean, where other enums seems to be self
> descriptive.
> Does it mean "inside basic block, but not BB start nor end?"
>

Start is just so you can do >start   <end for the enums :)
It doesn't mean anything.


Basic is just "a random operation with operands"
Better names welcome :)



>
>
> ================
> Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:65
> +  Expression(unsigned int o = ~2U)
> +      : EType(ExpressionTypeBase), Opcode(o) {}
> +  Expression(ExpressionType etype, unsigned int o = ~2U)
> ----------------
> You could call another ctor here like:
> Expression(unsigned int o = ..) : Expression(ExpressionTypeBase), o) {}
>

Yeah


>
>
> https://reviews.llvm.org/D26224
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161117/037c76ad/attachment.html>