[PATCH] D26224: NewGVN

[Piotr Padlewski via llvm-commits]

Prazek added inline comments.


================
Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:37
+  ExpressionTypeBasicStart,
+  ExpressionTypeBasic,
+  ExpressionTypeCall,
----------------
I am not really sure what does it mean, where other enums seems to be self descriptive.
Does it mean "inside basic block, but not BB start nor end?"



================
Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:65
+  Expression(unsigned int o = ~2U)
+      : EType(ExpressionTypeBase), Opcode(o) {}
+  Expression(ExpressionType etype, unsigned int o = ~2U)
----------------
You could call another ctor here like:
Expression(unsigned int o = ..) : Expression(ExpressionTypeBase), o) {}


https://reviews.llvm.org/D26224