[PATCH] D26671: Replace APFloatBase static fltSemantics data members with getter functions

[Stephan Bergmann via llvm-commits]

sberg retitled this revision from "Export llvm::APFloatBase static fltSemantics data members in extract_symbols.py" to "Replace APFloatBase static fltSemantics data members with getter functions".
sberg updated the summary for this revision.
sberg added a reviewer: chandlerc.
sberg updated this revision to Diff 78397.
sberg added a comment.
Herald added subscribers: nhaehnle, arsenm, jholewinski.
Herald added a reviewer: tstellarAMD.

- Replaced the data members with getter functions of the same names (or should they better be prefixed with get*, say?).

- Made the data private to APFloat.cpp (so everything outside of it needs to go via the getters, even in the same library; somewhat arbitrarily kept everything inside APFloat.cpp accessing the data directly).

- Checked additional repos tools/clang and tools/clang/tools/extra (which each needs a corresponding patch, which I'll submit once the details of this one are discussed), projects/libcxxabi (which mentions those data members' mangled names in test/test_demangle.pass.cpp, but apparently only as sample test data, so doesn't need changing?), projects/libcxx, and project/compiler-rt (which are unaffected).  Is there a list of more repos to check?  (And how would commits for such an incompatible cross-repo change be done atomically?)


https://reviews.llvm.org/D26671

Files:
  include/llvm/ADT/APFloat.h
  include/llvm/CodeGen/SelectionDAG.h
  include/llvm/IR/Type.h
  lib/Analysis/ConstantFolding.cpp
  lib/AsmParser/LLLexer.cpp
  lib/AsmParser/LLParser.cpp
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  lib/CodeGen/MachineInstr.cpp
  lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  lib/ExecutionEngine/ExecutionEngine.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/ConstantFold.cpp
  lib/IR/Constants.cpp
  lib/IR/Core.cpp
  lib/IR/LLVMContextImpl.h
  lib/IR/Verifier.cpp
  lib/MC/MCParser/AsmParser.cpp
  lib/Support/APFloat.cpp
  lib/Support/ScaledNumber.cpp
  lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/ARM/ARMMCInstLower.cpp
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/NVPTX/NVPTXAsmPrinter.cpp
  lib/Target/NVPTX/NVPTXInstrInfo.td
  lib/Target/NVPTX/NVPTXMCExpr.cpp
  lib/Target/X86/X86ISelLowering.cpp
  lib/Transforms/InstCombine/InstCombineCasts.cpp
  lib/Transforms/InstCombine/InstCombineCompares.cpp
  lib/Transforms/Utils/SimplifyLibCalls.cpp
  unittests/ADT/APFloatTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26671.78397.patch
Type: text/x-patch
Size: 215751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161117/6f74696b/attachment-0001.bin>