[PATCH] D26791: [AVX-512] Support FCOPYSIGN form v16f32 and v8f64

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 06:44:45 PST 2016


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:14858-14861
   assert((VT == MVT::f64 || VT == MVT::f32 || VT == MVT::f128 ||
           VT == MVT::v2f64 || VT == MVT::v4f64 || VT == MVT::v4f32 ||
-          VT == MVT::v8f32) &&
+          VT == MVT::v8f32 || VT == MVT::v8f64 || VT == MVT::v16f32) &&
          "Unexpected type in LowerFCOPYSIGN");
----------------
We see this kind of pattern a lot. I wonder if there's some way to generalize and unify these checks in a helper function, so we don't have to keep repeating it?


https://reviews.llvm.org/D26791





More information about the llvm-commits mailing list