[PATCH] D26795: [ELF] Better error reporting for linker scripts

[George Rimar via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1140
+      error(Location + Line);
+      error(Location + std::string(ErrLoc.second, ' ') + "^");
+      break;
----------------
In one of my latest patches I found that it is confusing to have multiple lines in output that are starting from "error: xxx".
I think we should not call error() for more than a single error at once.


================
Comment at: ELF/LinkerScript.cpp:1159
+  std::vector<StringRef> V = tokenize(Path, Data);
+  if (Tokens.empty())
+    Tokens = std::move(V);
----------------
<removed (have some issue with applying del on comment in phab, it does not want to do that. I have no time to wait until it do, so had to edit in that way)>


Repository:
  rL LLVM

https://reviews.llvm.org/D26795