[PATCH] D25963: [LoopUnroll] Implement profile-based loop peeling

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 18:55:22 PST 2016


mkuper added inline comments.


================
Comment at: lib/Transforms/Utils/LoopUtils.cpp:1089
+  if (!LatchBR->extractProfMetadata(TrueVal, FalseVal))
+    return None;
+
----------------
Actually, now that I think about this again, I'm not sure this is right.
Dehao, for instrumentation-based profiles, do back-edges of loops that are never taken get any profile metadata? I think they don't, in which case this should probably return 0.


https://reviews.llvm.org/D25963





More information about the llvm-commits mailing list