[PATCH] D26183: [compiler-rt] builtins: Allow building windows arm functions for mingw

[Martin Storsjö via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D26183#596097, @compnerd wrote:

> I think its nicer to split out the conversion functions for windows into a separate file that can be conditionally built.


Sure, will do.



================
Comment at: lib/builtins/arm/aeabi_idivmod.S:20
+#define __aeabi_idivmod __rt_sdiv
+#endif
+
----------------
compnerd wrote:
> Id rather sink this around the `DEFINE_COMPILERRT_FUNCTION`.  There is a single use, and that makes it more apparent that we are trying to rename the function.
Well, the same name is used at the end in `END_COMPILERRT_FUNCTION` as well, although that's a no-op on non-elf platforms. Do you still want the ifdef moved around `DEFINE_COMPILERRT_FUNCTION`, even though it no longer properly matches the corresponding no-op `END_COMPILERRT_FUNCTION` in that case?


https://reviews.llvm.org/D26183