[PATCH] D26765: GlobalISel: Fix unconditional fallback with global isel abort is disabled

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 13:11:41 PST 2016


tstellarAMD added a comment.

In https://reviews.llvm.org/D26765#597858, @t.p.northover wrote:

> Should that condition even be there? It seems like a selector may well want to add extra blocks and that's probably one of the benefits of GlobalISel.


There assertion right afterwards says that inserting blocks is not supported, so if that's true then I think  we need to keep it.


https://reviews.llvm.org/D26765





More information about the llvm-commits mailing list