[PATCH] D26733: [ELF][MIPS] Add MipsGotSection to handle MIPS GOT

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 12:41:32 PST 2016


On 16 November 2016 at 15:22, Simon Atanasyan <simon at atanasyan.com> wrote:
> atanasyan added inline comments.
>
>
> ================
> Comment at: ELF/Relocations.cpp:99
> +static unsigned handleNoRelaxTlsRelocation(
> +    GOT *Got, uint32_t Type, SymbolBody &Body, InputSectionBase<ELFT> &C,
> +    typename ELFT::uint Offset, typename ELFT::uint Addend, RelExpr Expr) {
> ----------------
> rafael wrote:
>> Got can be set in the function, no need to make it an argument.
>> Got can be set in the function, no need to make it an argument.
>
> I'm not sure that it is possible. GotSection used by ARM and MipsGotSection used by MIPS both have methods like addDynTlsEntry, getGlobalDynOffset etc but these methods are not virtual and are not defined in any base class. That is why I use GOT template argument.

Oops, I missed that. LGTM as is.

Thanks,
Rafael


More information about the llvm-commits mailing list