[PATCH] D26734: [ELF] Don't replace path separators on *NIX

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 11:12:57 PST 2016


ruiu added inline comments.


================
Comment at: test/ELF/reproduce-backslash.s:5-6
+# legal for a filename to contain backslashes.
+# RUN: rm -rf %t.dir
+# RUN: mkdir -p %t.dir/build
+# RUN: llvm-mc %s -o %t.dir/build/foo\\.o -filetype=obj -triple=x86_64-pc-linux
----------------
I don't think you need to to create a directory.


================
Comment at: test/ELF/reproduce-backslash.s:12
+
+# CHECK: repro/response.txt
+# CHECK: repro/{{.*}}/build/foo\.o
----------------
Checking the existence of response.txt is extraneous.


https://reviews.llvm.org/D26734





More information about the llvm-commits mailing list