[PATCH] D26716: DAG: Ignore call site attributes when emitting target intrinsic

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 10:31:27 PST 2016


efriedma requested changes to this revision.
efriedma added a reviewer: efriedma.
efriedma added a comment.
This revision now requires changes to proceed.

Why can't you just compute whether the intrinsic has a chain based on the IntrinsicInfo?  Checking for a readnone attribute in the IR seems dubious at best; an intrinsic can be both readnone and require a chain (for example, it could have undefined behavior for some inputs).


https://reviews.llvm.org/D26716





More information about the llvm-commits mailing list