[PATCH] D26749: Generate aeabi_cdcmple libcalls

[Saleem Abdulrasool via llvm-commits]

compnerd added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:11451
+  return true;
+}
+
----------------
This really feels wrong.  This really should be done earlier in the SDAG.  We could introduce a target specific SDNode for the operation.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:11457
+
+  if (getSubtarget()->isTargetAEABI() && rewriteEABICmpLibcalls(N, DAG))
+    return SDValue();
----------------
Shouldnt this also check for AAPCS?  The routines are written with AAPCS in mind.


================
Comment at: test/CodeGen/ARM/cdcmp.ll:1
+; RUN: llc -mcpu=cortex-m3 -mtriple=thumb-none-eabi %s -o - | FileCheck %s
+
----------------
Please add a test for Windows on ARM and ensure that the conversion is not done.


https://reviews.llvm.org/D26749