[PATCH] D26604: [ELF] - Added support for extern "c++" local symbols in version script.

[George Rimar via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1810
 
+void ScriptParser::readSymbols(std::vector<SymbolVersion> &V, bool Globals) {
+  for (;;) {
----------------
ruiu wrote:
> I don't think you need `Globals`. You could just stop reading until `local:` in any context.
That what seems obvious and was what I first think of.
But also it would parse something like next I think:

...
local:
<locals1>
local:
<local2>
...
It does not look clean.

Actually if you're ok with that, I am fine either, 
as I also do not like that flag.


https://reviews.llvm.org/D26604