[PATCH] D26719: Bitcode: Introduce initial multi-module reader API.

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/test/Bitcode/invalid.test:38
 BAD-TYPE-TABLE-FORWARD-REF: Invalid TYPE table: Only named structs can be forward referenced
-BAD-BITWIDTH: Bitwidth for integer type out of range
+BAD-BITWIDTH: Malformed block
 BAD-ALIGN: Invalid alignment value
----------------
pcc wrote:
> mehdi_amini wrote:
> > I'm surprised by this change, is it really intended? I suspect that some of your change is losing coverage here.
> > 
> > (Same on most of the changes below)
> Unfortunately some of our invalid bitcode files also have an invalid block size in addition to the problem under test, so we get an error trying to skip past the module in getBitcodeModuleList().
> 
> I'll see if I can restore coverage for these, but it may be some work as it will require binary patching of our test files.
Yeah that's really annoying. 
Maintaining invalid bitcode file across format change is not a great situation. I'd put this in the category of "unmaintainable test", especially in the absence of a code to easily generate them.


https://reviews.llvm.org/D26719