[PATCH] D26708: Fix -f[no-]reciprocal-math -ffast-math interaction, including LTO

Warren Ristow via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 22:09:25 PST 2016


wristow added a comment.

In https://reviews.llvm.org/D26708#596959, @majnemer wrote:

> In https://reviews.llvm.org/D26708#596623, @wristow wrote:
>
> > In https://reviews.llvm.org/D26708#596608, @majnemer wrote:
> >
> > > This change seems wrong.  Our IR defines `fast` as implying `arcp`: http://llvm.org/docs/LangRef.html#fast-math-flags
> >
> >
> > So the change to make `-ffast-math -fno-reciprocal-math` work should be (a) remove the `fast` flag, and (b) add all the other ones (except `arcp`) to each relevant place?
>
>
> This is the behavior I'd expect clang to have.


OK, thanks.  There's more discussion over on the mailing list, so I'll continue over there.


https://reviews.llvm.org/D26708





More information about the llvm-commits mailing list