[PATCH] D26255: [cmake] Add LLVM_ENABLE_DIA_SDK option, and expose it in LLVMConfig

Michał Górny via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 13:48:37 PST 2016


mgorny updated the summary for this revision.
mgorny updated this revision to Diff 78071.
mgorny added a comment.

Ok, I think that'd be the best version so far.

The option is now exposed on MSVC only, and defaults to autodetection result. If it is forced ON and DIA SDK is not available, it errors out verbosely and explains the potential problem (based on comment above the check). On non-MSVC platforms, LLVM_ENABLE_DIA_SDK is set to 0 for interoperability.

I've also went ahead and changed the #define name. The LLDB patch is already approved, so I can commit both simultaneously.


https://reviews.llvm.org/D26255

Files:
  cmake/config-ix.cmake
  cmake/modules/LLVMConfig.cmake.in
  docs/CMake.rst
  include/llvm/Config/config.h.cmake
  lib/DebugInfo/PDB/CMakeLists.txt
  lib/DebugInfo/PDB/PDB.cpp
  test/lit.site.cfg.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26255.78071.patch
Type: text/x-patch
Size: 4093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161115/9a34c376/attachment.bin>


More information about the llvm-commits mailing list