[PATCH] D26648: Clarify semantic of reserved registers.

[Krzysztof Parzyszek via llvm-commits]

kparzysz added inline comments.


================
Comment at: include/llvm/Target/TargetRegisterInfo.h:493
+  /// - is considered always live
+  /// - is ignored by liveness tracking
+  /// - It is often necessary to reserve the super registers of a reserved
----------------
If it's ignored by liveness tracking, then there is no meaning to "live" or "dead".  Maybe you could rephrase it (and the previous bullet) as something like "is ignored from the liveness point of view".


================
Comment at: include/llvm/Target/TargetRegisterInfo.h:496
+  ///   register as well, to avoid them getting allocated indirectly. You may
+  ///   use markSuperRegs() and assertAllSuperRegsMarked() in this case.
   virtual BitVector getReservedRegs(const MachineFunction &MF) const = 0;
----------------
This should be a standalone sentence, not a bullet in the list.


Repository:
  rL LLVM

https://reviews.llvm.org/D26648