[PATCH] D26255: [cmake] Add LLVM_ENABLE_DIA_SDK option, and expose it in LLVMConfig

[Michał Górny via llvm-commits]

mgorny added a comment.

In https://reviews.llvm.org/D26255#596037, @beanz wrote:

> If `LLVM_ENABLE_DIA_SDK` is `On` and you don't have a the SDK available that should be a fatal error. Treating it this way will also allow you to clean up some of the logic you're modifying in config-ix.cmake.


I was thinking about that but it seems that other options (like `LLVM_ENABLE_ZLIB`) also are non-fatal like this. While I don't mind changing this, I'm not sure how to do it properly so that it doesn't suddenly fail for a lot of users.

One option would be to detect DIA SDK first, and base the default off it. However, I don't see doing that cleanly without moving the option to config-ix. Another would be to make the option 'trinary', and put some special default like 'AUTO' — i.e. AUTO meaning use if present, ON meaning fail if non-present.

> Also gate the option under `WIN32` so it only shows up if you're targeting windows.

WIN32 or MSVC? The code is currently using the latter.


https://reviews.llvm.org/D26255