[PATCH] D26656: [COFF] Fix manifest resource file creation on Windows

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM. Thank you for fixing this!



================
Comment at: COFF/DriverUtils.cpp:591
+
+  std::vector<TemporaryFile> ResFiles;
+  ResFiles.reserve(MBs.size());
----------------
Please add a comment why we are doing this; we cannot pass paths of the files because the file may be a temporary file and in that case the path have already been removed.


https://reviews.llvm.org/D26656