[PATCH] D26191: [ARM] Patch to improve memcpy inlined assembly sequence.

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 09:55:52 PST 2016


t.p.northover added a comment.

This seems like a ridiculously specific optimization, even in its outline form. This is compounded by even more assumptions the actual implementation makes (that there will be GEPs for example).

The implementation is also really rather broken, but before we even get into details like that I think we need to sort out what benefit we'd get from a correct version. Basically, the high-level intent seems to be to optimize

  char arr[] = "whatever";

occurring in function scope. Is that really common enough to be worth writing an entire pass for?


https://reviews.llvm.org/D26191





More information about the llvm-commits mailing list