[PATCH] D26619: `update_test_checks.py` incorrectly truncates IR body

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 08:25:56 PST 2016


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.

A few general comments:

1. Although I checked this script in, my python skills are below beginner; for subsequent changes, feel free to find someone that actually knows something about coding in python. :)
2. There are probably lots of enhancements/bug fixes that could be made in this script; thanks for working on that!
3. I wanted this script to be a superset of update_llc_test_checks.py, so we could delete the original llc-only script. The only difference in the output that I know of is that I (probably foolishly) made a cosmetic change to include an extra comment line between the checks and the code. If you can make that an option/preference, then we should still be able to delete the original script before they diverge.


Repository:
  rL LLVM

https://reviews.llvm.org/D26619





More information about the llvm-commits mailing list