[PATCH] D26634: Make block placement determinisatic

[Rong Xu via llvm-commits]

xur updated this revision to Diff 77937.
xur added a comment.

Use SmallSetVector as suggested by the reviewers.


https://reviews.llvm.org/D26634

Files:
  MachineBlockPlacement.cpp


Index: MachineBlockPlacement.cpp
===================================================================
--- MachineBlockPlacement.cpp
+++ MachineBlockPlacement.cpp
@@ -264,7 +264,7 @@
 namespace {
 class MachineBlockPlacement : public MachineFunctionPass {
   /// \brief A typedef for a block filter set.
-  typedef SmallPtrSet<MachineBasicBlock *, 16> BlockFilterSet;
+  typedef SmallSetVector<MachineBasicBlock *, 16> BlockFilterSet;
 
   /// \brief work lists of blocks that are ready to be laid out
   SmallVector<MachineBasicBlock *, 16> BlockWorkList;
@@ -1512,7 +1512,7 @@
     }
     for (MachineBasicBlock *ChainBB : LoopChain) {
       dbgs() << "          ... " << getBlockName(ChainBB) << "\n";
-      if (!LoopBlockSet.erase(ChainBB)) {
+      if (!LoopBlockSet.remove(ChainBB)) {
         // We don't mark the loop as bad here because there are real situations
         // where this can occur. For example, with an unanalyzable fallthrough
         // from a loop block to a non-loop block or vice versa.
@@ -1928,7 +1928,7 @@
 
         // Handle the filter set
         if (BlockFilter) {
-          BlockFilter->erase(RemBB);
+          BlockFilter->remove(RemBB);
         }
 
         // Remove the block from loop info.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26634.77937.patch
Type: text/x-patch
Size: 1238 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161115/e6026cad/attachment.bin>