[PATCH] D26579: [cmake] Allow CMAKE_BUILD_TYPE=Gentoo

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 16:09:55 PST 2016


rnk added a comment.

In https://reviews.llvm.org/D26579#594953, @beanz wrote:

>   if(CMAKE_CXX_FLAGS_${uppercase_CMAKE_BUILD_TYPE} MATCHES "-DNDEBUG")
>
>
> This check instead checks to see if the configuration-specific flags contain "-DNDEBUG", which is really what we care about. I had a conversation with @gottesmm about this a while back.


This wouldn't support multi-configuration generators very well, though.


https://reviews.llvm.org/D26579





More information about the llvm-commits mailing list