[PATCH] D25590: Add initial support for WebAssembly binary format

[Sam Clegg via llvm-commits]

sbc100 added a comment.

Closing in favor of https://reviews.llvm.org/D26172



================
Comment at: lib/Object/WasmObjectFile.cpp:92
+      return make_error<GenericBinaryError>("Invalid opcode in init_expr",
+          object_error::invalid_file_type);
+  }
----------------
sunfish wrote:
> Here and at similar places elsewhere in this patch, object_error::parse_error would be more descriptive than object::invalid_file_type.
Fixed in the smaller PR: https://reviews.llvm.org/D26172


================
Comment at: lib/Object/WasmObjectFile.cpp:199
+        break;
+      default:
+        Err = make_error<GenericBinaryError>("Bad section type",
----------------
sunfish wrote:
> It'd be good to handle WASM_SEC_USER here too. If I understand the code here, we don't need to actually parse it, for now, similar to WASM_SEC_CODE above.
Fixed in smaller the PR: https://reviews.llvm.org/D26172


https://reviews.llvm.org/D25590