[compiler-rt] r286902 - [cfi] Mark some tests as requiring additional support from the MachO writer

[Vedant Kumar via llvm-commits]

Sorry about that, I'll switch it back to xfail just on Darwin.

vedant

> On Nov 14, 2016, at 3:19 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> 
> This would seem to disable the tests everywhere when we want them enabled everywhere except Darwin?
> 
> Peter
> 
> On Mon, Nov 14, 2016 at 2:50 PM, Vedant Kumar via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> Author: vedantk
> Date: Mon Nov 14 16:50:13 2016
> New Revision: 286902
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=286902&view=rev
> Log:
> [cfi] Mark some tests as requiring additional support from the MachO writer
> 
> These tests need to be marked as unsupported on Darwin:
> 
>   http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/1545
> 
> Modified:
>     compiler-rt/trunk/test/cfi/icall/external-call.c
>     compiler-rt/trunk/test/cfi/icall/weak.c
> 
> Modified: compiler-rt/trunk/test/cfi/icall/external-call.c
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/cfi/icall/external-call.c?rev=286902&r1=286901&r2=286902&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/cfi/icall/external-call.c (original)
> +++ compiler-rt/trunk/test/cfi/icall/external-call.c Mon Nov 14 16:50:13 2016
> @@ -4,7 +4,7 @@
> 
>  // This test uses jump tables containing PC-relative references to external
>  // symbols, which the Mach-O object writer does not currently support.
> -// XFAIL: darwin
> +// REQUIRES: rdar://problem/29255437
> 
>  #include <stdlib.h>
>  #include <stdio.h>
> 
> Modified: compiler-rt/trunk/test/cfi/icall/weak.c
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/cfi/icall/weak.c?rev=286902&r1=286901&r2=286902&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/cfi/icall/weak.c (original)
> +++ compiler-rt/trunk/test/cfi/icall/weak.c Mon Nov 14 16:50:13 2016
> @@ -1,5 +1,6 @@
>  // Test that weak symbols stay weak.
>  // RUN: %clang_cfi -lm -o %t1 %s && %t1
> +// REQUIRES: rdar://problem/29255437
> 
>  __attribute__((weak)) void does_not_exist(void);
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 
> 
> 
> -- 
> -- 
> Peter