[PATCH] D26524: [AArch64] Sink sext when foldable in user GEPs

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 15:19:47 PST 2016


mcrosier added inline comments.


================
Comment at: test/CodeGen/AArch64/aarch64-address-type-promotion-sink.ll:246
+if.then:
+; CHECK-LABEL: %if.then
+; CHECK-NOT: sxtw x{{[0-9]+}}, w{{[0-9]+}}
----------------
mcrosier wrote:
> I don't think you're using the CHECK-LABEL directive the way it is intended here (i.e., the %if.then label isn't unique to this file).  I suggest using a regular CHECK. 
You can ignore this comment.  I tried to remove it, but Phab wasn't taking the change.  I think your usage is okay..


https://reviews.llvm.org/D26524





More information about the llvm-commits mailing list