[PATCH] D25963: [LoopUnroll] Implement profile-based loop peeling

Haicheng Wu via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 14:55:16 PST 2016


haicheng added a comment.

Just a few nits.



================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:985
   unsigned TripMultiple = 1;
+
   // If there are multiple exiting blocks but one of them is the latch, use the
----------------
Unnecessary change.


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:1100
     auto &AC = getAnalysis<AssumptionCacheTracker>().getAssumptionCache(F);
+
     // For the old PM, we can't use OptimizationRemarkEmitter as an analysis
----------------
Unnecessary change.


================
Comment at: lib/Transforms/Utils/LoopUnrollPeel.cpp:212-214
+       ++VI) {
+    LVMap[VI->first] = VI->second;
+  }
----------------
Braces are not necessary.


https://reviews.llvm.org/D25963





More information about the llvm-commits mailing list