[PATCH] D26639: [tsan] Call pthread interceptors directly in TSan RTL unit tests

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 14:40:13 PST 2016


kubabrecka created this revision.
kubabrecka added reviewers: dvyukov, zaks.anna.
kubabrecka added a subscriber: llvm-commits.
kubabrecka set the repository for this revision to rL LLVM.
kubabrecka added a project: Sanitizers.

On Darwin, we're running the TSan unit tests without interceptors.  To make sure TSan observes all the pthread events (thread creating, thread join, condvar signal, etc.) in tsan_posix.cc, we should call the pthread interceptors directly, as we already do in tsan_test_util_posix.cc.  This fixes some flaky failures on Darwin bots.


Repository:
  rL LLVM

https://reviews.llvm.org/D26639

Files:
  lib/tsan/tests/rtl/tsan_posix.cc
  lib/tsan/tests/rtl/tsan_posix_util.h
  lib/tsan/tests/rtl/tsan_test_util_posix.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26639.77889.patch
Type: text/x-patch
Size: 13435 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161114/6e06f0f9/attachment.bin>


More information about the llvm-commits mailing list