[PATCH] D26585: [AMDGPU] Add wave barrier builtin

[Matt Arsenault via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:903-906
+  case AMDGPU::WAVE_BARRIER: {
+    MI.eraseFromParent();
+    break;
+  }
----------------
rampitec wrote:
> tstellarAMD wrote:
> > Does it matter that Post-RA scheduler runs after the Post-RA Pseudo Expansion pass?
> I do not think that is important. Scheduler will not move an instruction to a non-equivalent control flow block.
I think this should be emitted in the asm printer as a comment rather than deleting it during codegen passes


Repository:
  rL LLVM

https://reviews.llvm.org/D26585