[PATCH] D26638: Don't pass nullptr into memcpy

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 14:13:01 PST 2016


vitalybuka updated this revision to Diff 77887.
vitalybuka added a comment.

return early


https://reviews.llvm.org/D26638

Files:
  include/llvm/DebugInfo/MSF/ByteStream.h


Index: include/llvm/DebugInfo/MSF/ByteStream.h
===================================================================
--- include/llvm/DebugInfo/MSF/ByteStream.h
+++ include/llvm/DebugInfo/MSF/ByteStream.h
@@ -91,6 +91,9 @@
   uint32_t getLength() const override { return ImmutableStream.getLength(); }
 
   Error writeBytes(uint32_t Offset, ArrayRef<uint8_t> Buffer) const override {
+    if (Buffer.empty())
+      return Error::success();
+
     if (Data.size() < Buffer.size())
       return make_error<MSFError>(msf_error_code::insufficient_buffer);
     if (Offset > Buffer.size() - Data.size())


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26638.77887.patch
Type: text/x-patch
Size: 599 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161114/4b8000fe/attachment.bin>


More information about the llvm-commits mailing list