[PATCH] D26634: Make block placement determinisatic

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 14:06:17 PST 2016


davidxl added inline comments.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:1498
+   // matching clang binary in bootstrap build.
+   for (MachineBasicBlock &LoopBB : *F)
+     if (LoopBlockSet.count(&LoopBB))
----------------
This fix has compile time implication. Two alternatives:
1) make collectLoopBlockSet to also compute a vector of blocks in fixed order
or
2) change BlockFilterSet to be a set of integers where the integer is MBB's unique id: getNumber()


https://reviews.llvm.org/D26634





More information about the llvm-commits mailing list