[PATCH] D26568: [ADT] Delete Twine constructors which accept StringRef rvalues (NFC)

Jordan Rose via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 11:15:53 PST 2016


jordan_rose added a comment.

I'm inclined to agree with @dblaikie's email comment: assigning a Twine is pretty much never safe anyway, so we should just delete `operator=` altogether. (I'd love to get rid of the copy-constructor too and just allow moves, but I think it still makes sense to copy-construct when combining a Twine argument with multiple different suffixes.)


https://reviews.llvm.org/D26568





More information about the llvm-commits mailing list