[PATCH] D26593: [X86][GlobalISel] Add minimal call lowering support to the IRTranslator

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 13 21:35:08 PST 2016


hfinkel added a comment.

In https://reviews.llvm.org/D26593#593918, @davide wrote:

> Picking this one (but the same applies to the ARM global isel skeleton commit).
>  I'm a little bit concerned to see various targets moving to global isel without proper scrutiny, as already pointed out by @echristo on llvm-dev. Don't get me wrong, I'm personally very excited about the whole idea, and it's likely that my organization will put some resources on it in the foreseeable future, but I would be less worried if Eric's concerns are addressed before moving forward.


Frankly, I see no better way to give GlobalISel the scrutiny it requires than by starting to port backends to it. We just need to have the right mindset about it.


Repository:
  rL LLVM

https://reviews.llvm.org/D26593





More information about the llvm-commits mailing list