[PATCH] D26593: [X86][GlobalISel] Add minimal call lowering support to the IRTranslator

Zvi Rackover via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 13 13:05:49 PST 2016


zvi added a comment.

In https://reviews.llvm.org/D26593#593918, @davide wrote:

> Picking this one (but the same applies to the ARM global isel skeleton commit).
>  I'm a little bit concerned to see various targets moving to global isel without proper scrutiny, as already pointed out by @echristo on llvm-dev. Don't get me wrong, I'm personally very excited about the whole idea, and it's likely that my organization will put some resources on it in the foreseeable future, but I would be less worried if Eric's concerns are addressed before moving forward.


I believe that @echristo's concern was about running in a mixed mode of existing ISel (SelectionDAG) and Global ISel, but better let him speak for himself.
At the moment I am not aware of plans to run the X86 ISel in such a mixed mode. This patch is intended to jumpstart implemention of the X86 part of the Global Isel as designed by the team lead by Quentin and in par with the documentation. The development team presented the current status of the work on Global ISel at the recent dev meeting, and called out to developers of other targets to join this effort. We agreed that we could start development of the X86 part in low gear and speed-up after some additional work will be completed, mainly related to tablegen uses.


Repository:
  rL LLVM

https://reviews.llvm.org/D26593





More information about the llvm-commits mailing list