[PATCH] D26488: [GVN] Basic optimization remark support

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 21:35:42 PST 2016


anemet added a comment.

In https://reviews.llvm.org/D26488#593529, @hfinkel wrote:

> Should we update the message to also provide the location/type of the store? (or the other load for the PRE case).


Which store, the one that we forward from?  I did that in https://reviews.llvm.org/D26489.

> When we have debug information on the variable, should we print its name/type from the debug info? (This might be useful when we have aggregates, for example, especially after SROA is done with them). I'm happy for this to be done in follow-up if you agree it is useful.

Yes I agree, we should explore this further.


https://reviews.llvm.org/D26488





More information about the llvm-commits mailing list