[PATCH] D26562: Bitcode: Change module reader functions to return an llvm::Expected.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 20:50:15 PST 2016


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks.



================
Comment at: llvm/unittests/Bitcode/BitReaderTest.cpp:61
+  if (!ModuleOrErr)
+    report_fatal_error("Could not parse bitcode module");
   return std::move(ModuleOrErr.get());
----------------
Any error was just ignored before? What was the behavior on error?


https://reviews.llvm.org/D26562





More information about the llvm-commits mailing list