[PATCH] D26548: [ELF] - Better diagnostic for "can't create dynamic relocation" error.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:651-652
     bool Preemptible = isPreemptible(Body, Type);
-    Expr = adjustExpr(File, Body, IsWrite, Expr, Type, Buf + RI.r_offset);
+    Expr = adjustExpr(File, Body, IsWrite, Expr, Type, Buf + RI.r_offset, C,
+                      RI.r_offset);
     if (HasError)
----------------
This function already took too much parameters. I wouldn't add new parameters that can be inferred from other parameters.

Don't pass C because it should be reachable from Body.


https://reviews.llvm.org/D26548